Enable Signet #64
Enable Signet #64
Conversation
yellowred
requested review from
a team and
JasonCWang
and removed request for
a team
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| entity(id: $entity_id) { | ||
| ... on Account { | ||
| transactions(, first: $first, after: $after, types: $types, after_date: $after_date, before_date: $before_date, bitcoin_network: $bitcoin_network, lightning_node_id: $lightning_node_id, statuses: $statuses, exclude_failures: $exclude_failures) { | ||
| transactions(, first: $first, after: $after, types: $types, after_date: $after_date, before_date: $before_date, bitcoin_network: $bitcoin_network, lightning_node_id: $lightning_node_id, statuses: $statuses, exclude_failures: $exclude_failures, max_amount: $max_amount, min_amount: $min_amount) { |
There was a problem hiding this comment.
There appears to be a syntax error in the GraphQL query - an extra comma exists after the opening parenthesis in the transactions function call. This should be removed to prevent GraphQL parsing errors.
// Incorrect:
transactions(, first: $first, after: $after, ...)
// Should be:
transactions(first: $first, after: $after, ...)The same issue appears in other queries in this file as well (payment_requests, withdrawal_requests). These extra commas should be removed for proper GraphQL syntax.
| transactions(, first: $first, after: $after, types: $types, after_date: $after_date, before_date: $before_date, bitcoin_network: $bitcoin_network, lightning_node_id: $lightning_node_id, statuses: $statuses, exclude_failures: $exclude_failures, max_amount: $max_amount, min_amount: $min_amount) { | |
| transactions(first: $first, after: $after, types: $types, after_date: $after_date, before_date: $before_date, bitcoin_network: $bitcoin_network, lightning_node_id: $lightning_node_id, statuses: $statuses, exclude_failures: $exclude_failures, max_amount: $max_amount, min_amount: $min_amount) { |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| @@ -1,5 +1,6 @@ | |||
| // Copyright ©, 2023-present, Lightspark Group, Inc. - All Rights Reserved | |||
| use crate::objects::connection::Connection; | |||
| use crate::objects::lightspark_node::LightsparkNode; | |||
There was a problem hiding this comment.
Remove this unused import for LightsparkNode. It's not being used in this file and is causing a compiler warning.
Spotted by Diamond (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
|
Too many errors, solved my problem using Sparkcore signing for now. |
Towards LPT-225